Repository navigation
Conversation
d815b6d (Read a G7 directly on the watch) linked and embedded G7SensorKit in the WatchApp target for WatchDeviceManagers.swift, which imports it. LoopKit#2645 removed the framework's file reference and both build files, but left the reference in the WatchApp's Frameworks build phase, which then pointed at nothing. A clean build failed to resolve G7SensorKit for the WatchApp, and a build that found it in old DerivedData linked it without embedding it. This restores the three objects as d815b6d had them.
Contributor
Author
|
duplicate of https://github.com/LoopKit/Loop/pull/2652/changes ? |
Contributor
Author
|
Duplicate of #2652, which restores the same G7SensorKit entries and also drops the three dangling OmnipodKit/RileyLink references. Verified the same G7SensorKit change: a fresh LoopWorkspace next-dev clone with Loop at next-dev + this fix builds from empty DerivedData, and the watch app embeds G7SensorKit.framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watch app imports
G7SensorKit(WatchApp Extension/Managers/WatchDeviceManagers.swift, from d815b6d "Read a G7 directly on the watch"), but since #2645 the WatchApp target no longer links or embeds it.What happens on next-dev
G7SensorKit.frameworksucceeds, so this is easy to miss.@rpath/G7SensorKit.framework/G7SensorKit(Swift auto-linking from the import), butWatch/WatchApp.app/Frameworkshas only LoopKit and LoopCore. On a watch it would fail to load that library at launch.Cause
d815b6d added three objects to
Loop.xcodeproj/project.pbxprojfor the WatchApp target:F8760AF3…(G7SensorKit.framework, built products)921B7FAE…(link)101AA737…(Embed Frameworks)4d700ab (#2645) removed all three, and their entries in the WatchApp's Embed Frameworks phase and the Frameworks group. It left
921B7FAE… /* G7SensorKit.framework in Frameworks */in the WatchApp's Frameworks build phase, pointing at an object that no longer exists; Xcode ignores it.Fix
Restore the three objects as d815b6d had them, with the Embed Frameworks and group entries (+5 lines,
project.pbxprojonly).Verified
plutil -lintpasses.next-dev(1321af1), with Loop at this branch (next-dev f7b08ca plus this commit), builds theLoopWorkspacescheme for the iOS Simulator from empty DerivedData: BUILD SUCCEEDED.Frameworksnow hasG7SensorKit.framework,LoopKit.frameworkandLoopCore.framework.(Unrelated, left as is: next-dev also defines the build file
8B5CF014… /* LoopKit.framework in Frameworks */twice, identically. Xcode tolerates it.)